Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Register workspace authz metrics #2248

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Oct 20, 2022

Summary

We added some metrics in #2246 but forgot to register them.

With this PR, we now see:

$ k --user shard-admin get --raw /metrics|grep workspace_authorizer
# HELP workspace_authorizer_caches [ALPHA] Number of caches
# TYPE workspace_authorizer_caches counter
workspace_authorizer_caches{type="org"} 1
workspace_authorizer_caches{type="root"} 1
# HELP workspace_authorizer_invalidations [ALPHA] Number of cache invalidations
# TYPE workspace_authorizer_invalidations counter
workspace_authorizer_invalidations{type="org"} 3
workspace_authorizer_invalidations{type="root"} 3
# HELP workspace_authorizer_sync_duration_seconds [ALPHA] Cache sync latency in seconds.
# TYPE workspace_authorizer_sync_duration_seconds histogram
workspace_authorizer_sync_duration_seconds_bucket{result="skip",type="org",le="0.0001"} 55
.....

Related issue(s)

Fixes #

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc
Copy link
Member Author

ncdc commented Oct 20, 2022

/cherry-pick release-0.9

@openshift-cherrypick-robot

@ncdc: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022
@openshift-merge-robot openshift-merge-robot merged commit 69aed0a into kcp-dev:main Oct 20, 2022
@openshift-cherrypick-robot

@ncdc: new pull request created: #2249

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants