✨ *: migrate to use cluster-aware apiextensions-apiserver clients, listers and informers #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/api-change
stevekuznetsov
commented
Oct 24, 2022
| @@ -372,13 +367,8 @@ func (c *apiBindingAwareCRDLister) getForWildcardPartialMetadata(name string) (* | |||
| return objs[0].(*apiextensionsv1.CustomResourceDefinition), nil | |||
| } | |||
|
|
|||
| func (c *apiBindingAwareCRDLister) getSystemCRD(clusterName logicalcluster.Name, name string) (*apiextensionsv1.CustomResourceDefinition, error) { | |||
There was a problem hiding this comment.
This particular diff looked suspicious, so I walked it back and it's been doing the same thing inside and outside of the if for a couple months now :)
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/migrate-apiextensions-clientset
branch
from
1473633
to
0066464
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*: remove old skip annotations for the automated refactor
go.mod: bump to newer kcp-dev/client-go
*: manual edits to use cluster-aware apiextensions client
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
*: autogenerated changes to use cluster-aware apiextensions client
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/assign @ncdc @sttts @p0lyn0mial