🐛 Avoid syncers deleting namespace from other synctargets.

[jmprusi]

Summary

This PR adds an additional check (synctarget UID) when deleting downstream namespaces to avoid a reconciliation loop between different syncers from different kcp instances. (or for example, an old syncer from a previous KCP deployment)

Related issue(s)

related to: #2041 (doesn't fix it as there are multiple root causes for that issue)

[davidfestal]

/approve
/lgtm

[davidfestal]

/test

[openshift-ci]

@davidfestal: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

• /test boilerplate
• /test codegen
• /test deps
• /test e2e
• /test e2e-multiple-runs
• /test images
• /test imports
• /test lint
• /test modules
• /test test

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[davidfestal]

/test all

[stevekuznetsov]

If we're hitting flakes please let's make sure we file issues for them with logs

[jmprusi]

@stevekuznetsov no flakes.. but the GitHub actions being stuck (not loading)

[davidfestal]

/test all

[davidfestal]

/test

[openshift-ci]

@davidfestal: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

• /test boilerplate
• /test codegen
• /test deps
• /test e2e
• /test e2e-multiple-runs
• /test images
• /test imports
• /test lint
• /test modules
• /test test

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[davidfestal]

/test e2e-sharded

[openshift-ci]

@davidfestal: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test boilerplate
• /test codegen
• /test deps
• /test e2e
• /test e2e-multiple-runs
• /test images
• /test imports
• /test lint
• /test modules
• /test test

Use /test all to run all jobs.

In response to this:

/test e2e-sharded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmprusi]

/test e2e

[jmprusi]

/test e2e-sharded

[openshift-ci]

@jmprusi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test boilerplate
• /test codegen
• /test deps
• /test e2e
• /test e2e-multiple-runs
• /test images
• /test imports
• /test lint
• /test modules
• /test test

Use /test all to run all jobs.

In response to this:

/test e2e-sharded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmprusi]

/test all

[jmprusi]

@davidfestal I've force pushed to trigger the jobs that didn't start. can you add lgtm again? thanks!

[davidfestal]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/syncer/OWNERS [davidfestal,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment