Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 .github: restrict kind tests to those that require it #2275

Conversation

stevekuznetsov
Copy link
Contributor

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

Depends on openshift/release#33497

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@ncdc
Copy link
Member

ncdc commented Oct 27, 2022

LG. Do you want to keep the job names as-is, or adjust to indicate they use kind in some way?

@stevekuznetsov
Copy link
Contributor Author

I don't want to have to figure out migrations for in-flight PRs etc, so I think keeping it this way makes sense for now?

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
Copy link
Contributor Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2022
@nrb
Copy link
Contributor

nrb commented Oct 27, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2022
@stevekuznetsov
Copy link
Contributor Author

/retest

1 similar comment
@stevekuznetsov
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit af30cd7 into kcp-dev:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants