Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 test/e2e/framework: Don't try to pull logs from a non-ready POD #2283

Merged

Conversation

jmprusi
Copy link
Member

@jmprusi jmprusi commented Oct 31, 2022

Summary

Fixes some flaky tests due to the syncer-dns pod not being in "running" state (synctarget heartbeat is sent by the syncer pod, and doesn't take into account the syncer-dns POD state.)

This is causing some e2e-shared tests to fail, due to the collecting of logs failing as the syncer-dns pod is not ready.

related to: #2284

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2022
@stevekuznetsov
Copy link
Contributor

If the pod has stopped, etc, we can get the previous logs from it - can we add that as well?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2022
@jmprusi
Copy link
Member Author

jmprusi commented Oct 31, 2022

If the pod has stopped, etc, we can get the previous logs from it - can we add that as well?

done! ptal.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmprusi
Copy link
Member Author

jmprusi commented Nov 2, 2022

Not sure what went wrong here:

WARN[2022-11-01T12:45:25Z] Unable to retrieve logs from failed build     error=build src is in an error state. No logs are available.
[10](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/kcp-dev_kcp/2283/pull-ci-kcp-dev-kcp-main-e2e-sharded/1587424934290788354#1:build-log.txt%3A10)
INFO[2022-[11](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/kcp-dev_kcp/2283/pull-ci-kcp-dev-kcp-main-e2e-sharded/1587424934290788354#1:build-log.txt%3A11)-01T12:45:25Z] Ran for 2m20s                                
11
ERRO[2022-11-01T[12](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/kcp-dev_kcp/2283/pull-ci-kcp-dev-kcp-main-e2e-sharded/1587424934290788354#1:build-log.txt%3A12):45:25Z] Some steps failed:                           
12
ERRO[2022-11-01T12:45:25Z] 
[13](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/kcp-dev_kcp/2283/pull-ci-kcp-dev-kcp-main-e2e-sharded/1587424934290788354#1:build-log.txt%3A13)
  * could not run steps: step src failed: could not get build src: builds.build.openshift.io "src" not found

/retest

@openshift-merge-robot openshift-merge-robot merged commit fe25bb1 into kcp-dev:main Nov 2, 2022
@jmprusi jmprusi deleted the jmprusi/non-ready-pods-flaky branch November 2, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants