-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 test/e2e/framework: Don't try to pull logs from a non-ready POD #2283
🐛 test/e2e/framework: Don't try to pull logs from a non-ready POD #2283
Conversation
If the pod has stopped, etc, we can get the previous logs from it - can we add that as well? |
done! ptal. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not sure what went wrong here:
/retest |
Summary
Fixes some flaky tests due to the syncer-dns pod not being in "running" state (synctarget heartbeat is sent by the syncer pod, and doesn't take into account the syncer-dns POD state.)
This is causing some e2e-shared tests to fail, due to the collecting of logs failing as the syncer-dns pod is not ready.
related to: #2284