-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Fix incorrect cleaning of deletion annotations #2288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Signed-off-by: David Festal <dfestal@redhat.com>
@@ -188,6 +188,9 @@ func TestComputePlacement(t *testing.T) { | |||
}, map[string]string{ | |||
"state.workload.kcp.dev/cluster-3": "Sync", | |||
}, nil, nil, "ns"), | |||
wantAnnotationPatch: map[string]interface{}{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sttts do you agree that the test was previously wrong, or was it on purpose that the deletion annotation would be kept even when rescheduling to the SyncTarget ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure. Leaving that to @qiujian16 and @jmprusi
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Summary
This PR fixes an incorrect cleaning of SyncTarget-related deletion annotations.
Related issue(s)
Fixes #2287