Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ sharded-test-server: support for running the caching layer #2320

Conversation

p0lyn0mial
Copy link
Contributor

Summary

adds support for running the cache-server to the sharded-test-server binary.
support for caching can be turned on by passing --run-cache-server=true flag, then the test binary will:

  1. configure the cache to listen on port 8012 (HTTPS)
  2. configure the cache to use embedded-etcd (ports 8010, 8011)
  3. configure the cache to use filepath.Join(workingDir, ".kcp-cache") directory
  4. run the cache server
  5. wait for the cache server's serving certificate
  6. use the certificate to create a kubeconfig at the path configured in 3
  7. wait until the cache becomes ready

next, the test binary will configure each shard with the following flags:

  1. --run-cache-server=true - inherited from the test binary itself
  2. --cache-server-kubeconfig-file - that points to the kubeconfig created in step 6. A shard will use the config to establish connection with the cache server

in the future we could run the caching layer by default, for now (until it proves to work), it has to be gated with a flag.

Related issue(s)

part of #342

@sttts
Copy link
Member

sttts commented Nov 8, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit f05dd96 into kcp-dev:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants