✨ Only schedule to synctarget with compatible APIs #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/api-change
davidfestal
reviewed
Nov 9, 2022
pkg/reconciler/workload/placement/placement_reconcile_scheduling_test.go
Show resolved
Hide resolved
qiujian16
changed the title
davidfestal
reviewed
Nov 14, 2022
davidfestal
reviewed
Nov 14, 2022
davidfestal
reviewed
Nov 14, 2022
qiujian16
force-pushed
the
schedule-compatible
branch
from
ea00e76
to
d789215
Compare
openshift-merge-robot
added
the
needs-rebase
qiujian16
force-pushed
the
schedule-compatible
branch
from
d789215
to
4b7c9d1
Compare
openshift-merge-robot
removed
the
needs-rebase
davidfestal
approved these changes
Nov 15, 2022
|
/assign @sttts |
sttts
reviewed
Nov 15, 2022
sttts
reviewed
Nov 15, 2022
qiujian16
force-pushed
the
schedule-compatible
branch
from
a315436
to
c8d456d
Compare
davidfestal
reviewed
Nov 17, 2022
pkg/reconciler/workload/apibindinglabel/apibindinglabel_controller.go
Outdated
Show resolved
Hide resolved
davidfestal
reviewed
Nov 17, 2022
pkg/reconciler/workload/apibindinglabel/apibindinglabel_indexes.go
Outdated
Show resolved
Hide resolved
davidfestal
reviewed
Nov 17, 2022
pkg/reconciler/workload/apibindinglabel/apibindinglabel_indexes.go
Outdated
Show resolved
Hide resolved
davidfestal
reviewed
Nov 17, 2022
ncdc
added
the
area/transparent-multi-cluster
qiujian16
force-pushed
the
schedule-compatible
branch
2 times, most recently
from
c281b5e
to
d386672
Compare
openshift-merge-robot
added
the
needs-rebase
qiujian16
force-pushed
the
schedule-compatible
branch
from
d386672
to
6f3eddb
Compare
davidfestal
reviewed
Nov 29, 2022
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
schedule-compatible
branch
from
d4549d7
to
d9a051b
Compare
|
/lgtm |
sttts
reviewed
Nov 29, 2022
sttts
reviewed
Nov 29, 2022
sttts
reviewed
Nov 29, 2022
sttts
reviewed
Nov 29, 2022
sttts
reviewed
Nov 29, 2022
sttts
reviewed
Nov 29, 2022
pkg/reconciler/workload/placement/placement_reconcile_scheduling.go
Outdated
Show resolved
Hide resolved
sttts
reviewed
Nov 29, 2022
pkg/reconciler/workload/placement/placement_reconcile_scheduling.go
Outdated
Show resolved
Hide resolved
sttts
reviewed
Nov 29, 2022
sttts
reviewed
Nov 29, 2022
sttts
reviewed
Nov 29, 2022
| ) | ||
|
|
||
| const ( | ||
| ControllerName = "kcp-api-export-extra-annotation-sync" |
There was a problem hiding this comment.
this looks like controller inflation. Why not add another reconciler to the existing apibinding controller.
There was a problem hiding this comment.
existing apibinding controller only update status using committer. committer cannot update label and status once, and cannot remove the label key. If we add another reconciler in the apibinding controller, I think it will make it a bit messy, since we need to patch labels separately in this reconciler then return the updated placement to let other reconciler update status.
There was a problem hiding this comment.
we have precedence for that, see the clusterworkspaces controller. The only rules to follow:
- each reconciler either modifies status or spec, not both
- all status reconcilers come first, and reconciliation it stopped (+ requeued) when spec is changed.
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
schedule-compatible
branch
from
36dccd9
to
640ec60
Compare
sttts
reviewed
Nov 30, 2022
pkg/reconciler/apis/extraannotationsync/apibindingannotation_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
schedule-compatible
branch
from
f35e23b
to
733c727
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
sttts
reviewed
Dec 9, 2022
| if placement.Status.Phase == schedulingv1alpha1.PlacementPending || placement.Status.SelectedLocation == nil { | ||
| conditions.MarkFalse(placement, |
There was a problem hiding this comment.
this is a big 🔴 . Never ever mutate in a getter.
sttts
reviewed
Dec 9, 2022
| } | ||
|
|
||
| if len(filteredSyncTargets) == 0 { | ||
| conditions.MarkFalse(placement, |
There was a problem hiding this comment.
another one 🔴 . Don't mutate anything when it is not clearly expected by the function name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a filter to filter out synctarget whose supported resouces do not include what in the apibindings.
Signed-off-by: Jian Qiu jqiu@redhat.com
Summary
filter the synctarget based on what is the supported resource in synctarget and what is the served apibindings relating to compute in this workspace.
Related issue(s)
Fixes #1779