🌱 go.mod: bump to pick up cluster-aware apiextensions clients #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
force-pushed
the
skuznets/cluster-aware-apiextensions
branch
2 times, most recently
from
2cb36e6
to
deffcbd
Compare
openshift-merge-robot
added
the
needs-rebase
stevekuznetsov
force-pushed
the
skuznets/cluster-aware-apiextensions
branch
from
deffcbd
to
864d776
Compare
openshift-merge-robot
removed
the
needs-rebase
ncdc
reviewed
Nov 15, 2022
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Until we can import *just* the API types and clients, we need to use this copy in kcp and in our fork. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Notably, the genericcontrolplane one was also setting our content-type, so do it explicitly. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
We were previously starting more than one informer factory for CRDs. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
We already do this for kcp startup. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
The cluster-aware clients add a prefix to the path, which we need to strip before asking the k8s libraries to parse request info out of it. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/cluster-aware-apiextensions
branch
from
864d776
to
6ec9f81
Compare
ncdc
approved these changes
Nov 15, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-sharded |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
Proof for kcp-dev/kubernetes#114