Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Lookup DNS IP in Service #2367

Merged
merged 1 commit into from
Nov 16, 2022
Merged

馃悰 Lookup DNS IP in Service #2367

merged 1 commit into from
Nov 16, 2022

Conversation

lionelvillard
Copy link
Contributor

@lionelvillard lionelvillard commented Nov 15, 2022 •
edited

Summary

  • Get the DNS IP address from the Service object.
  • Rename BoundWorkspace to WorkspaceBound

Related issue(s)

Fixes #2365

@lionelvillard lionelvillard force-pushed the fix-iplookup branch 5 times, most recently from bbfd266 to cd7a243 Compare November 16, 2022 15:46
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2022
@lionelvillard lionelvillard changed the title 馃悰 Lookup the DNS IP in Service 馃悰 Lookup DNS IP in Service Nov 16, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2022
@lionelvillard
Copy link
Contributor Author

/hold

testing with David fixes.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2022
@lionelvillard
Copy link
Contributor Author

lionelvillard commented Nov 16, 2022 •
edited

Got this error:

virtualworkspace_test.go:558: Patch luckyluke via virtual workspace to report in status that joe is in prison
I1116 18:50:29.484716   50955 spec_process.go:350] "Updated upstream resource with syncer finalizer" syncTarget.workspace="root:e2e-org-dgpv2:e2e-workspace-bjvgl" syncTarget.name="wildwest-356231" syncTarget.key="2oMmwW6bPkUX2W07XmZgfjISikTMIbUBI6fpoK" reconciler="kcp-workload-syncer-spec" key="root:e2e-org-dgpv2:e2e-workspace-bjvgl|kcp-system/kube-root-ca.crt" gvr="/v1, Resource=configmaps"
I1116 18:50:29.485041   50955 spec_controller.go:288] "processing key" syncTarget.workspace="root:e2e-org-dgpv2:e2e-workspace-bjvgl" syncTarget.name="wildwest-356231" syncTarget.key="2oMmwW6bPkUX2W07XmZgfjISikTMIbUBI6fpoK" reconciler="kcp-workload-syncer-spec" key="root:e2e-org-dgpv2:e2e-workspace-bjvgl|kcp-system/default-token-flt7f" gvr="/v1, Resource=secrets"
I1116 18:50:29.487713   50955 spec_controller.go:246] "queueing GVR" syncTarget.workspace="root:e2e-org-dgpv2:e2e-workspace-bjvgl" syncTarget.name="wildwest-356231" syncTarget.key="2oMmwW6bPkUX2W07XmZgfjISikTMIbUBI6fpoK" reconciler="kcp-workload-syncer-spec" key="root:e2e-org-dgpv2:e2e-workspace-bjvgl|kcp-system/kube-root-ca.crt" gvr="/v1, Resource=configmaps"
    virtualworkspace_test.go:560: 
        	Error Trace:	virtualworkspace_test.go:560
        	            				virtualworkspace_test.go:1460
        	Error:      	Received unexpected error:
        	            	Internal error occurred: tried to write resource cowboys:ec4f85f4e25edbc3278635fb61ec25f11881ff964f621e96b30c8fe3b9836426/status(default/luckyluke) though it is not owning it (syncer finalizer doesn't exist)

FYI @davidfestal @jmprusi

@davidfestal
Copy link
Member

Got this error:

virtualworkspace_test.go:558: Patch luckyluke via virtual workspace to report in status that joe is in prison
I1116 18:50:29.484716   50955 spec_process.go:350] "Updated upstream resource with syncer finalizer" syncTarget.workspace="root:e2e-org-dgpv2:e2e-workspace-bjvgl" syncTarget.name="wildwest-356231" syncTarget.key="2oMmwW6bPkUX2W07XmZgfjISikTMIbUBI6fpoK" reconciler="kcp-workload-syncer-spec" key="root:e2e-org-dgpv2:e2e-workspace-bjvgl|kcp-system/kube-root-ca.crt" gvr="/v1, Resource=configmaps"
I1116 18:50:29.485041   50955 spec_controller.go:288] "processing key" syncTarget.workspace="root:e2e-org-dgpv2:e2e-workspace-bjvgl" syncTarget.name="wildwest-356231" syncTarget.key="2oMmwW6bPkUX2W07XmZgfjISikTMIbUBI6fpoK" reconciler="kcp-workload-syncer-spec" key="root:e2e-org-dgpv2:e2e-workspace-bjvgl|kcp-system/default-token-flt7f" gvr="/v1, Resource=secrets"
I1116 18:50:29.487713   50955 spec_controller.go:246] "queueing GVR" syncTarget.workspace="root:e2e-org-dgpv2:e2e-workspace-bjvgl" syncTarget.name="wildwest-356231" syncTarget.key="2oMmwW6bPkUX2W07XmZgfjISikTMIbUBI6fpoK" reconciler="kcp-workload-syncer-spec" key="root:e2e-org-dgpv2:e2e-workspace-bjvgl|kcp-system/kube-root-ca.crt" gvr="/v1, Resource=configmaps"
    virtualworkspace_test.go:560: 
        	Error Trace:	virtualworkspace_test.go:560
        	            				virtualworkspace_test.go:1460
        	Error:      	Received unexpected error:
        	            	Internal error occurred: tried to write resource cowboys:ec4f85f4e25edbc3278635fb61ec25f11881ff964f621e96b30c8fe3b9836426/status(default/luckyluke) though it is not owning it (syncer finalizer doesn't exist)

FYI @davidfestal @jmprusi

This might simply be because, in this test case, we don't wait for the syncer to add the finalizer before trying to patch the resource. So if the syncer is slower to add the finalizer, this would fail here.

@davidfestal
Copy link
Member

/test test

@davidfestal
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2022
@lionelvillard
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2022
@openshift-merge-robot openshift-merge-robot merged commit 25aa52f into kcp-dev:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfestal davidfestal davidfestal left review comments

@jmprusi jmprusi Awaiting requested review from jmprusi

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@davidfestal davidfestal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Retrieve the workspace-related CoreDNS IP from the Service resource instead of using DNS lookup.
3 participants
@lionelvillard @davidfestal @openshift-merge-robot