Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 migrate kcp clientset #2378

Merged
merged 39 commits into from
Nov 21, 2022
Merged

🌱 migrate kcp clientset #2378

merged 39 commits into from
Nov 21, 2022

Conversation

stevekuznetsov
Copy link
Contributor

@stevekuznetsov stevekuznetsov commented Nov 17, 2022 •
edited by sttts

Depends on kcp-dev/kubernetes#111

Error: failed: Your PR description is really short.
Error: failed: Your PR description is really short.
Error: failed: Your PR description is really short.
Error: failed: Your PR description is really short.
Error: failed: Your PR description is really short.
Error: failed: Your PR description is really short.
Error: failed: Your PR description is really short.
Error: failed: Your PR description is really short.
Error: failed: Your PR description is really short.
Error: failed: Your PR description is really short.
Error: failed: Your PR description is really short.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2022
@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 17, 2022
@stevekuznetsov
Revert "Merge pull request kcp-dev#2380 from qiujian16/reuse-index"
c497e42 
This reverts commit d5d74cc, reversing
changes made to 93888e4.
@stevekuznetsov
pkg/client: generate cluster-aware clients, listers and informers
c61a710 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
*: remove last skip annotations for the auto-refactor
24fd246 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
committer: use runtime.Object, cluster-aware clients
3d8a129 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
clusterworkspacetypeexists: update custom fakes
b7d8a87 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
*: stop using implicit *rest.Config behavior
d991ebe 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
cache: don't stringly-type logicalcluster.Name
88d8ed4 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
virtual/framework: remove filtered tenancy lister
6123080 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
virtual/workspaces: update custom fakes in watch test
1802a31 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
pkg/virtual/authorization: parse keys
78efbd8 
Why are these not strongly-typed? Can we refactor this in the future.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
pkg/virtual/workspaces/cache: simplify this cache
7488a48 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
generated
e73ce59
@stevekuznetsov
syncer: use correct types in single-cluster controllers
9cdd276 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
*: semi-automated refactors for kcp clientset
6d5ea78 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
test/e2e: generate cluster-aware clients for wildwest
d3284fc 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
*: semi-automated changes to use kcp clientset
1c2a18b 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
*: update to docs
a7cd33f 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
generated changes to kcp clientset itself
84d53e4 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
generated changes for wildwest clientset
7ca3ad0 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
*: remove our copy of key functions
df7c596 
The upstream cache.MetaNamespaceKeyFunc no longer silently considers
clusters, so we can just use that one.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
test-server: don't tail kcp startup logs unless verbose
eabe118 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
test-server: parse and present more intelligent startup errors
036c251 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
bootstrap: be more verbose about what's going wrong
1773602 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
test/e2e: use -v 4 like we do for the server
f9bbc6c 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
test/e2e: be explicit about discovery
252a100 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
*: stop using kcpclienthelper
f47fe27 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
*: make the linters pass
24de8bf 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
test-server: only stop streaming once
07871e8 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
proxy: make index controller cluster-scoped
f29d43f 
ClusterWorkspaceShard objects are only valid if they are in the root
cluster, so we are better off using a cluster-scoped client + informers
here.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
pkg/admission: fix a typo from GoLand refactoring
5e917b9 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
pkg/authorization: simplify test logic
0085e95 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022

New changes are detected. LGTM label has been removed.

@stevekuznetsov stevekuznetsov added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022

New changes are detected. LGTM label has been removed.

@stevekuznetsov
Copy link
Contributor Author

Forgot to bump client-go as well ... re-tagging

@stevekuznetsov stevekuznetsov added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@stevekuznetsov
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022

New changes are detected. LGTM label has been removed.

@stevekuznetsov
go.mod: bump to latest k8s
c6695e5 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@stevekuznetsov
client-gen: use spaces ...
9c4601e 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022

New changes are detected. LGTM label has been removed.

@stevekuznetsov stevekuznetsov added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@stevekuznetsov
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 5916c3c into kcp-dev:main Nov 21, 2022
@stevekuznetsov stevekuznetsov mentioned this pull request Nov 21, 2022
Closed
1 task
@ncdc ncdc mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@fgiloux fgiloux fgiloux left review comments

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

@csams csams Awaiting requested review from csams

@davidfestal davidfestal Awaiting requested review from davidfestal

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stevekuznetsov @sttts @fgiloux @p0lyn0mial @openshift-merge-robot