Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Further cleanup to tmc-related e2e tests #2379

Merged

Conversation

davidfestal
Copy link
Member

@davidfestal davidfestal commented Nov 17, 2022

Signed-off-by: David Festal dfestal@redhat.com

Summary

Further cleanup to tmc-related e2e tests:

  • we should always add the CRDs for deployments, services, endpoints in the fake pclusters, since they are now all required by the Syncer to correctly work.
  • In a Syncer Virtual Workspace test, we should have been waiting for the Syncer finalizer bing set before trying to patch the resource.
  • Rewite of the Syncer virtual workspace tests to avoid starting 2 syncers when it's not necessary.
  • Cleanup the way Syncer are started to sync user workspaces, and remove the need of the BoundWorkload method.

Additional fixes on code bugs found at this occasion:

  • Skip the kcp-system in namespace and resource scheduling (was obviously bringing much load for nothing)
  • Small fix in the workload sync command, to avoid adding a nil APIExport reference in the SupportedAPIExports
  • ...

Related issue(s)

Required changes that should fix some flakes and race-condition-related bugs.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2022
@davidfestal
Copy link
Member Author

/test e2e-shared

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2022
@davidfestal davidfestal force-pushed the fix-syncer-ws-flaky-e2e-tests branch 2 times, most recently from 2adae30 to f72d9ef Compare November 22, 2022 23:06
@davidfestal
Copy link
Member Author

/test shared

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2022

@davidfestal: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test boilerplate
  • /test codegen
  • /test deps
  • /test e2e
  • /test e2e-multiple-runs
  • /test e2e-sharded
  • /test e2e-shared
  • /test images
  • /test imports
  • /test lint
  • /test modules
  • /test test

Use /test all to run all jobs.

In response to this:

/test shared

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidfestal
Copy link
Member Author

/test e2e-shared

@davidfestal
Copy link
Member Author

/test e2e-sharded

Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal changed the title WIP 馃悰 Further cleanup to tmc-related e2e tests 馃悰 Further cleanup to tmc-related e2e tests Nov 23, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2022
@jmprusi
Copy link
Member

jmprusi commented Nov 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@davidfestal
Copy link
Member Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0b87067 into kcp-dev:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants