Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 CLI: Better error messages to bind compute #2424

Conversation

davidfestal
Copy link
Member

Summary

Provide more detailed error messages when the bind compute CLI command fails with a timeout error.

Related issue(s)

No related issue. Encountered this need when working on PR #2336

@davidfestal davidfestal changed the title CLI: Better error messages to bind compute bug: CLI: Better error messages to bind compute Nov 29, 2022
@davidfestal davidfestal changed the title bug: CLI: Better error messages to bind compute 🐛 CLI: Better error messages to bind compute Nov 29, 2022
@davidfestal davidfestal force-pushed the better-error-reporting-on-compute-bind branch 2 times, most recently from 933d4c8 to 2c27fdb Compare November 29, 2022 11:13
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal force-pushed the better-error-reporting-on-compute-bind branch from 2c27fdb to 5cc8fb6 Compare November 29, 2022 11:26
@davidfestal
Copy link
Member Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2022
Copy link
Contributor

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2022
@openshift-merge-robot openshift-merge-robot merged commit bd94929 into kcp-dev:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants