-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 Contextual logging fixes #2445
Conversation
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@@ -149,13 +149,15 @@ func (c *APIReconciler) enqueueAPIResourceSchema(obj interface{}, logger logr.Lo | |||
return | |||
} | |||
|
|||
logger = logger.WithValues("cluster", clusterName, "name", name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use WithObject on the APIResourceSchema
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@@ -149,7 +149,9 @@ func (c *APIReconciler) enqueueAPIResourceSchema(obj interface{}, logger logr.Lo | |||
return | |||
} | |||
|
|||
logger = logger.WithValues("cluster", clusterName, "name", name) | |||
if logObj, ok := obj.(logging.Object); ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We know it must be an APIResourceSchema, which is a logging object, but this works too :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Summary
Move the following to contextual logging
Also disables the newly-introduced key name check for the time being.
Related issue(s)
Fixes #