Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 cliplugins/bind: fix incorrect error message #2447

Conversation

jmprusi
Copy link
Member

@jmprusi jmprusi commented Dec 2, 2022

Summary

When binding a workspace to compute, if some of the apibindings is not ready, the bind cli will output an error like:

error: bind compute is not ready placement-23sk5wr9: not bound to apiexport 'root:compute:root:compute': Unable to bind APIs: naming conflict with a bound API kubernetes, spec.names.plural=pods is...

This error is confusing, as the workspace is duplicated, and doesn't specify the export name: 'root:compute:root:compute'

This PR changes it to include the name of the export, as in: 'root:compute:kubernetes'

@jmprusi
Copy link
Member Author

jmprusi commented Dec 2, 2022

TestSyncerLifecycle: Null Spec in deployment

/retest

@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit 33bab53 into kcp-dev:main Dec 2, 2022
@jmprusi jmprusi deleted the jmprusi/fix-incorrect-binding-error-message branch December 2, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants