馃悰 Remove list SyncTarget in bind compute cmd #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
approved these changes
Dec 5, 2022
openshift-ci
bot
added
lgtm
|
/retest |
|
/lgtm cancel Namespace scheduler test failures look real |
|
/hold need to also remove apiexport create controller in this PR. |
openshift-ci
bot
added
the
do-not-merge/hold
qiujian16
force-pushed
the
rm-list-synctarget
branch
from
3fcbdec
to
a75f614
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
we would do that in a next PR. |
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
rm-list-synctarget
branch
from
a75f614
to
57696c4
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jian Qiu jqiu@redhat.com
Summary
do not list synctarget during bind compute cmd, as it will bring authz issue.
Related issue(s)
Fixes #2349