馃悰Syncer: Remaining fixes on downstream namespace cleaning #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
added
the
area/transparent-multi-cluster
ncdc
reviewed
Dec 6, 2022
Co-authored-by: Andy Goldstein <andy.goldstein@gmail.com>
|
/test e2e-sharded |
|
/assign @ncdc |
|
@ncdc The |
|
@davidfestal that's not a required test, so it won't block merging. @jmprusi can you please review this? |
|
@jmprusi is on vacation this week. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/test e2e-shared |
kcp-ci-bot
added
the
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Remaining fixes on downstream namespace cleaning in the Syncer
Related issues
No dedicated issue.
This fixes issues found in the code when working on issue kcp-dev/contrib-tmc#80