馃悰 Add missing battery annotation for root-compute-workspace #2474
Conversation
| @@ -1,6 +1,9 @@ | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| kind: ClusterRole | |||
| metadata: | |||
| annotations: | |||
| bootstrap.kcp.dev/create-only: "true" | |||
There was a problem hiding this comment.
Do we really want to use createOnly here ?
Don't we want the policy to be updated if necessary at every restart, in order to update the rules for every resource ? Never updating it seems strange to me, and will make future additions of GVRs in the root:compute:kubernetes APIExport quite hard.
By the way the same question stands for the apiexport-kubernetes.k8s.io.yaml file.
@sttts thoughts ?
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
missing-bataries
branch
from
21421cb
to
fee0196
Compare
openshift-ci
bot
added
lgtm
|
kcp-dev/contrib-tmc#93 |
|
#2479 |
|
Not sure why the GH actions jobs for e2e-sharded and e2e-shared-server are not running. I'm going to close and reopen the PR to see if that will trigger them. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test e2e-sharded |
|
/test test Flake kcp-dev/contrib-tmc#69 |
Signed-off-by: Jian Qiu jqiu@redhat.com
Summary
the annotation should be added to all resources in root:compute workspace
Related issue(s)
Fixes #2406