馃悰 Syncer: add 'get' permission on downstream namespaces #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
approved these changes
Dec 12, 2022
openshift-ci
bot
added
lgtm
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
add-get-namespaces-perm-downstream
branch
from
f5c33dd
to
f11fbd7
Compare
|
Flake kcp-dev/contrib-tmc#93 |
|
@ncdc I need your lgtm again after my changes. |
ncdc
approved these changes
Dec 12, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Flake #2479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some cases, especially when some concurrency occurs while creating the downstream namespace, the syncer might need to
geta just-created namespace.But currently the
syncerservice account isn't granted thegetpermission on downstream namespaces, though it is granted bothlistandwatch. This PR adds thegetverb to the syncer cluster role.Related issue(s)
No related issue. Bug identified during the tests of another PR.