Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 WorkspaceType admission should respect LimitAllow{Parents, Children}.None #2588

Merged
merged 1 commit into from
Jan 10, 2023
Merged

馃悰 WorkspaceType admission should respect LimitAllow{Parents, Children}.None #2588

merged 1 commit into from
Jan 10, 2023

Conversation

vincepri
Copy link
Contributor

Signed-off-by: Vince Prignano vincepri@redhat.com

Summary

Related issue(s)

Fixes #2582

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2023
@openshift-ci openshift-ci bot requested review from ncdc and sttts January 10, 2023 17:34
@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 10, 2023
@vincepri vincepri changed the title WIP: 馃悰 WorkspaceType admission should respect LimitAllowParents.None 馃悰 WorkspaceType admission should respect LimitAllowParents.None Jan 10, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2023
@vincepri vincepri changed the title 馃悰 WorkspaceType admission should respect LimitAllowParents.None 馃悰 WorkspaceType admission should respect LimitAllow{Parents, Children}.None Jan 10, 2023
Signed-off-by: Vince Prignano <vincepri@redhat.com>
@vincepri
Copy link
Contributor Author

/assign @sttts

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit 95c4b1a into kcp-dev:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Root Type Workspace Under Non-Admin User Workspace
5 participants