🐛 Role and ClusterRole merger should not modify cache objects #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
vincepri
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
sttts
reviewed
Jan 12, 2023
| } | ||
|
|
||
| // The Role is a new one, deepcopy it in the current array. | ||
| current = append(current, cachedRole.DeepCopy()) |
There was a problem hiding this comment.
use DeepCopyInto. It saves allocations.
There was a problem hiding this comment.
Why don't we keep track of deepcopied roles and only do it when the second instance is seen?
|
/lgtm I think we can improve that even more. But this stops the bleeding. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This reverts commit 0831b69.
Signed-off-by: Vince Prignano <vincepri@redhat.com>
|
/lgtm |
AlainRoy
reviewed
Jan 12, 2023
| @@ -0,0 +1,208 @@ | |||
| /* | |||
| Copyright 2021 The KCP Authors. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano vincepri@redhat.com
Summary
This PR also reverts 0831b69
Related issue(s)
Fixes #