馃悰 Add bind permission for kubernetes apiexport #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jian Qiu <jqiu@redhat.com>
|
maybe also need to backport to 0.10.0? |
I assume it would be good yes. |
davidfestal
approved these changes
Jan 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
unhold now that an issue has been created to track to requirement, for the related and similar e2e tests, to test also with unprivileged users: kcp-dev/contrib-tmc#62 |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
@qiujian16 see my answer above. Do you want to do it ? |
astefanutti
added a commit
to astefanutti/camel-kcp
that referenced
this pull request
Feb 1, 2023
astefanutti
added a commit
to astefanutti/camel-kcp
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jian Qiu jqiu@redhat.com
Summary
Related issue(s)
Fixes #2597