🐛 e2e/watchcache: use cluster client for creating content in a workspace #2632
Conversation
previously the tests were trying to create content in a workspace by providing a full path which couldn't have been resolved by the local proxy.
| wsPath, _ := framework.NewWorkspaceFixture(t, server, orgPath, framework.WithRootShard()) | ||
| rootShardConfig := server.RootShardSystemMasterBaseConfig(t) | ||
| clusterConfig := server.BaseConfig(t) |
There was a problem hiding this comment.
does this really change the URL? both BaseConfig and RootShardSystemMasterBaseConfig point to the base URL.
There was a problem hiding this comment.
yes, in a multi-shard env BaseConfig point to a kubeconfig for the front-proxy whereas RootShardSystemMasterBaseConfig points to a kubeconfig for the root shard :)
There was a problem hiding this comment.
in a single shard env it doesn't matter
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
If you're hitting flaky tests, please try to add a link to the flake issue when you add a retest comment. If there is no flake issue, please file one. Thanks! |
okay! this is the first time i have seen |
|
I filed for that and have a fix |
|
2644 |
Summary
previously the tests were trying to create content in a workspace by providing a full path which couldn't have been resolved by the local proxy.
Related issue(s)
xref: #2596