Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 test/e2e: add support for dynamic users using client certs #2640

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

s-urbaniak
Copy link
Contributor

Summary

This adds support to generate users on the fly in e2e tests. Currently, only users predefined in a token fixture file can be used. This allows for more descriptive user names and also allows adding groups dynamically.

Related issue(s)

N/A

@s-urbaniak
Copy link
Contributor Author

oh we need to add some logic to handle the sharded use case which uses a dedicated client cert for the front proxy.

@s-urbaniak s-urbaniak changed the title 🌱 test/e2e: add support for dynamic users using client certs WIP 🌱 test/e2e: add support for dynamic users using client certs Jan 18, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2023
@s-urbaniak s-urbaniak force-pushed the e2e-client-certs branch 2 times, most recently from 8dbaf6f to 57f8858 Compare January 25, 2023 11:18
@s-urbaniak s-urbaniak changed the title WIP 🌱 test/e2e: add support for dynamic users using client certs 🌱 test/e2e: add support for dynamic users using client certs Jan 25, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2023
@s-urbaniak
Copy link
Contributor Author

/test e2e-shared

@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 786ebb8 into kcp-dev:main Jan 25, 2023
@s-urbaniak s-urbaniak deleted the e2e-client-certs branch January 25, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants