🐛 pkg/reconciler/apis/apibinding: return error in case of conflicts

[s-urbaniak]

Summary

This fixes failed local sharded startup failures. The observed symptom was:

- apiVersion: apis.kcp.io/v1alpha1
  kind: APIBinding
  metadata:
    annotations:
      kcp.io/cluster: system:shard
    creationTimestamp: "2023-01-18T14:29:39Z"
    finalizers:
    - apis.kcp.io/apibinding-finalizer
    generation: 1
    labels:
      internal.apis.kcp.io/export: bmCdly9xXiUpEHe3ypvDwvXMTfoVZUE92mqAQf
    name: tenancy.kcp.io
    resourceVersion: "195"
    uid: 9cf38f12-663c-4673-84be-b5aae0cb4bdc
  spec:
    reference:
      export:
        name: tenancy.kcp.io
        path: root
  status:
    conditions:
    - lastTransitionTime: "2023-01-18T14:29:42Z"
      message: 'Unable to bind APIs: error checking for naming conflicts for APIBinding
        system:shard|tenancy.kcp.io: error getting CRDs: APIResourceSchema.apis.kcp.io
        "v220628-546034da.negotiatedapiresources.apiresource.kcp.io" not found'
      reason: NamingConflicts
      severity: Error
      status: "False"
      type: Ready
    - lastTransitionTime: "2023-01-18T14:29:41Z"
      message: Invalid APIExport. Please contact the APIExport owner to resolve
      reason: InternalError
      severity: Error
      status: "False"
      type: APIExportValid
    - lastTransitionTime: "2023-01-18T14:29:42Z"
      message: 'Unable to bind APIs: error checking for naming conflicts for APIBinding
        system:shard|tenancy.kcp.io: error getting CRDs: APIResourceSchema.apis.kcp.io
        "v220628-546034da.negotiatedapiresources.apiresource.kcp.io" not found'
      reason: NamingConflicts
      severity: Error
      status: "False"
      type: BindingUpToDate
    - lastTransitionTime: "2023-01-18T14:29:42Z"
      message: 'Unable to bind APIs: error checking for naming conflicts for APIBinding
        system:shard|tenancy.kcp.io: error getting CRDs: APIResourceSchema.apis.kcp.io
        "v220628-546034da.negotiatedapiresources.apiresource.kcp.io" not found'
      reason: NamingConflicts
      severity: Error
      status: "False"
      type: InitialBindingCompleted
    phase: Binding

In case of temporary failures the api binding controller didn't retry.

This fixes it.

Related issue(s)

N/A

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ncdc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[p0lyn0mial]

@s-urbaniak some unit tests are failing :( (https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/kcp-dev_kcp/2645/pull-ci-kcp-dev-kcp-main-test/1615726119036653568)

[p0lyn0mial]

/lgtm