Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Deflake quota e2e #2688

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Jan 26, 2023

Summary

Properly check for forbidden errors within Eventually blocks

Related issue(s)

Fixes #2685

Properly check for forbidden errors within Eventually blocks

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc
Copy link
Member Author

ncdc commented Jan 26, 2023

/assign @stevekuznetsov

@hardys
Copy link

hardys commented Jan 31, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
@ncdc
Copy link
Member Author

ncdc commented Jan 31, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@ncdc
Copy link
Member Author

ncdc commented Feb 1, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7d55514 into kcp-dev:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: flake: quota
4 participants