馃尡 manifest: remove outdated manifests #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
In the community call we agreed to remove these and go ahead with updating the helm-charts repo instead (which contains similar manifests which are templated)
|
/test e2e-sharded Looks like kcp-dev/contrib-tmc#77 flake |
|
/retest |
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the community call we agreed to remove these and go ahead with updating the helm-charts repo instead (which contains similar manifests which are templated)
The helm-charts repo is also outdated, but I pushed a PR aiming to resolve that, and since we probably don't have capacity to maintain the manifests in both places it was agreed to remove these.
Also I did look into how we might revive these using kustomize, but it looks difficult due to the templating we need for externalHostname (and choice of ingress resource type) - AFAICS helm is a better fit for our requirements so we can support multiple versions and configurations.