馃尡 More APIExport VW e2e deflaking #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
commented
Feb 1, 2023
ncdc
force-pushed
the
deflake-apiexport-vw-test
branch
2 times, most recently
from
c0e5ca1
to
4193747
Compare
|
/test e2e-sharded |
|
/lgtm |
Wrap some more things in Eventually blocks to deal with eventual consistency in a multi-shard setup. Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
ncdc
force-pushed
the
deflake-apiexport-vw-test
branch
from
4193747
to
c7a62d7
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap creating an APIBinding in an Eventually block to give the system time to be eventually consistent.
Change the expected error when service provider 2 tries to list cowboys in a workspace where the APIBinding shadowed a CRD.
Fixes #2732