Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 E2E failing on APIExportEndpointSlice creation (flake) #2755

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

fgiloux
Copy link
Contributor

@fgiloux fgiloux commented Feb 7, 2023

Summary

Fix a possible flake where the referenced APIExport may not be available on the cache server before the APIExportEndpointSlice is created.

Signed-off-by: Frederic Giloux fgiloux@redhat.com

Related issue(s)

Fixes #2740

@fgiloux fgiloux requested a review from ncdc February 7, 2023 15:30
@fgiloux fgiloux changed the title 🐛 Fix a possible flake where the referenced APIExport may not be availa… 🐛 E2E failing on APIExportEndpointSlice creation (flake) Feb 7, 2023
…ble on the cache server before the APIExportEndpointSlice is created.

Signed-off-by: Frederic Giloux <fgiloux@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@ncdc
Copy link
Member

ncdc commented Feb 7, 2023

kcp-dev/contrib-tmc#78
/retest

@fgiloux
Copy link
Contributor Author

fgiloux commented Feb 7, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit 1235ac4 into kcp-dev:main Feb 7, 2023
@kcp-ci-bot kcp-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: TestAPIExportEndpointSliceWithPartitionPrivate
4 participants