Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix git in Prow #2769

Merged
merged 1 commit into from
Feb 8, 2023
Merged

🌱 Fix git in Prow #2769

merged 1 commit into from
Feb 8, 2023

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Feb 8, 2023

Summary

Newer versions of git have a security measure in place to prevent git from parsing the .git/config file or running any hooks if the user running git is not the owner of the repository files. Prow runs as a random UID, which is not guaranteed to be the same as the UID that owns the cloned files, so this change disables the ownership check and considers all cloned repositories "safe" regardless of owner.

Related issue(s)

Fixes #

Newer versions of git have a security measure in place to prevent git
from parsing the .git/config file or running any hooks if the user
running git is not the owner of the repository files. Prow runs as a
random UID, which is not guaranteed to be the same as the UID that owns
the cloned files, so this change disables the ownership check and
considers all cloned repositories "safe" regardless of owner.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ncdc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncdc ncdc changed the title Fix git in Prow 🌱 Fix git in Prow Feb 8, 2023
@ncdc
Copy link
Member Author

ncdc commented Feb 8, 2023

Looks like this fixed the issue. Self-merging to unblock other PRs.

@ncdc ncdc merged commit 561880e into kcp-dev:main Feb 8, 2023
@ncdc ncdc deleted the fix-prow-git-issue branch February 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant