🐛 Fix location cannot be found by placement during scheduling #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold for a e2e test to verify |
openshift-ci
bot
added
the
do-not-merge/hold
qiujian16
force-pushed
the
fix-location-placement
branch
from
6e0ea6e
to
dc3e3f6
Compare
davidfestal
suggested changes
Feb 14, 2023
yeah, this is reason I am holding this PR |
qiujian16
force-pushed
the
fix-location-placement
branch
from
dc3e3f6
to
3a322fc
Compare
|
e2e added |
openshift-ci
bot
removed
the
do-not-merge/hold
qiujian16
force-pushed
the
fix-location-placement
branch
2 times, most recently
from
32cd0a8
to
b6461a7
Compare
davidfestal
reviewed
Feb 20, 2023
It happens when setting the alternative workspace name on placement, which needs to be considered during scheduling Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
fix-location-placement
branch
from
b6461a7
to
a9340d9
Compare
davidfestal
approved these changes
Feb 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jian Qiu jqiu@redhat.com
Summary
It happens when setting the alternative workspace name on placement, which needs to be considered during scheduling
Related issue(s)
Fixes #2737