Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update link for investigations directory #2801

Conversation

cychiang
Copy link
Contributor

Summary

The link for investigations directory in docs website is pointing to a 404 page. It might be good to point to the investigations folder in GitHub instead of 404 page.

@openshift-ci openshift-ci bot requested review from jmprusi and ncdc February 16, 2023 15:07
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2023

Hi @cychiang. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ncdc
Copy link
Member

ncdc commented Feb 16, 2023

Thanks for catching this! Instead of linking to GitHub, how about deleting this sentence entirely? Thanks!

@cychiang
Copy link
Contributor Author

This The [investigations directory](https://github.com/kcp-dev/kcp/tree/main/docs/content/en/investigations) is where we will capture specific deep dive details. entire sentence? Even better I think, those topics in the investigations directory seem been mentioned in the Key Concepts section except self-service-policy. Should I ignore it for now?

docs/content/en/GOALS.md Outdated Show resolved Hide resolved
Remove investigations directory sentence.

Co-authored-by: Andy Goldstein <andy.goldstein@gmail.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@ncdc
Copy link
Member

ncdc commented Feb 16, 2023

/ok-to-test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2023
@openshift-merge-robot openshift-merge-robot merged commit 02cfa8e into kcp-dev:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants