Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 docs: simplify i18n #2852

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Mar 1, 2023

Summary

Simplify docs i18n using the mkdocs-static-i18n plugin.

Remove docker option and switch to venv for docs generation.

This also fixes the broken search issue.

Related issue(s)

Fixes #2843
Fixes #2802
Fixes #2850

@ncdc ncdc added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Simplify docs i18n using the mkdocs-static-i18n plugin.

Remove docker option and switch to venv for docs generation.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc ncdc requested a review from nrb March 1, 2023 16:24
@ncdc ncdc removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2023
@ncdc ncdc marked this pull request as ready for review March 1, 2023 16:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2023
@openshift-ci openshift-ci bot requested review from csams and davidfestal March 1, 2023 16:32
@sttts
Copy link
Member

sttts commented Mar 1, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2023
@nrb
Copy link
Contributor

nrb commented Mar 1, 2023

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 92554ad into kcp-dev:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Make kcp-docs-image does not works on linux/arm64 docs: search is broken docs: broken links
4 participants