Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 split pkg/client with go workspaces #2869

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Mar 6, 2023

Summary

Split pkg/client to separate the module

Follow-up PR will be needed to replace with real version once we publish first version

Related issue(s)

Fixes #2794
Supersedes #2676
Supersedes #2192

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

go.mod Outdated Show resolved Hide resolved
@mjudeikis mjudeikis changed the title ✨ split pkg/client with go workspaces 🌱 split pkg/client with go workspaces Mar 6, 2023
@mjudeikis mjudeikis force-pushed the go.workspaces branch 4 times, most recently from f6fdc91 to ebebab3 Compare March 6, 2023 12:07
@mjudeikis mjudeikis marked this pull request as ready for review March 6, 2023 12:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2023
@openshift-ci openshift-ci bot requested review from ncdc and sttts March 6, 2023 12:35
@mjudeikis mjudeikis requested review from stevekuznetsov and sttts and removed request for ncdc and sttts March 6, 2023 12:35
@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis mjudeikis force-pushed the go.workspaces branch 2 times, most recently from 312205a to d23d9a2 Compare March 6, 2023 13:28
@ncdc
Copy link
Member

ncdc commented Mar 6, 2023

Will review more thoroughly later, but one thing I wanted to mention quickly is about go.work. I don't think we want to check that in to the repo? I think that's usually something developers could/would customize locally. I'd actually probably add it to .gitignore...

@ncdc
Copy link
Member

ncdc commented Mar 6, 2023

Follow-up PR will be needed to replace with real version once we publish first version

We should be able to keep it as 0.0.0 in the repo and not need to replace it with the published version.

@mjudeikis
Copy link
Contributor Author

Got ya. I think you can ignore this until Ci is green. Neet to nurture it down until all parts works ;/

@mjudeikis mjudeikis force-pushed the go.workspaces branch 2 times, most recently from c767064 to de794aa Compare March 6, 2023 17:21
cmd/apigen/go.mod Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
cmd/apigen/go.mod Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
@mjudeikis
Copy link
Contributor Author

mjudeikis commented Mar 9, 2023

cleaned the root go.mod to be minimal change. All the other child go.mod are just being aligned with root one now.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit c7108fa into kcp-dev:main Mar 13, 2023
@mjudeikis mjudeikis deleted the go.workspaces branch March 13, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Unable to use KCP client set
3 participants