🐛 Decouple internal and external logical-cluster-admin access #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/hold This is WIP until I fix the e2e tests - currently there is an assumption that |
openshift-ci
bot
added
the
do-not-merge/hold
|
/cc @sttts |
sttts
reviewed
Mar 9, 2023
sttts
reviewed
Mar 9, 2023
hardys
force-pushed
the
logical_cluster_admin_fix
branch
2 times, most recently
from
d167291
to
98c5407
Compare
|
/retitle 🐛 Decouple internal and external logical-cluster-admin access |
openshift-ci
bot
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
sttts
reviewed
Mar 14, 2023
sttts
reviewed
Mar 14, 2023
hardys
force-pushed
the
logical_cluster_admin_fix
branch
from
98c5407
to
e14c629
Compare
hardys
commented
Mar 16, 2023
|
/hold Still figuring out authz for the new external-logical-cluster-admin group |
openshift-ci
bot
added
the
do-not-merge/hold
hardys
force-pushed
the
logical_cluster_admin_fix
branch
from
e14c629
to
a32b89e
Compare
openshift-ci
bot
added
the
kind/api-change
hardys
force-pushed
the
logical_cluster_admin_fix
branch
from
a32b89e
to
ddf4f7f
Compare
|
/hold cancel @sttts @s-urbaniak this is ready for another review pass when you get a moment, thanks! |
openshift-ci
bot
removed
the
do-not-merge/hold
hardys
force-pushed
the
logical_cluster_admin_fix
branch
from
3cc8c8c
to
5c0128c
Compare
s-urbaniak
reviewed
Mar 22, 2023
s-urbaniak
reviewed
Mar 22, 2023
s-urbaniak
reviewed
Mar 22, 2023
hardys
force-pushed
the
logical_cluster_admin_fix
branch
from
5c0128c
to
be119dc
Compare
|
/test e2e-sharded Looks like #2865 |
s-urbaniak
reviewed
Mar 23, 2023
hardys
force-pushed
the
logical_cluster_admin_fix
branch
from
be119dc
to
a5bfb36
Compare
|
/lgtm |
hardys
pushed a commit
to hardys/helm-charts
that referenced
this pull request
Mar 23, 2023
Requires kcp-dev/kcp#2882 Fixes: kcp-dev#32
|
@sttts this is ready for another review pass when you get time please - it's blocker for rebasing deployments based on the helm templates |
sttts
reviewed
Mar 24, 2023
hardys
force-pushed
the
logical_cluster_admin_fix
branch
from
a5bfb36
to
e129761
Compare
sttts
reviewed
Mar 24, 2023
The current logical-cluster-admin config is used for both internal shard-direct access, and also for access via the front-proxy. This won't work when the CA certs for the shard and front-proxy are different, so we add a new flag to specify an external config that enables access via the front-proxy - the existing config should be configured to enable access direct to the shards. This is derived from 339a071 which was reverted in 3854f1b Co-Authored-By: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
The group evaluation is already done prior to the switch, returning early if either group is found, so this test for non-membership is redundant.
hardys
force-pushed
the
logical_cluster_admin_fix
branch
from
e129761
to
36aa88c
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
hardys
pushed a commit
to hardys/helm-charts
that referenced
this pull request
Mar 27, 2023
Requires kcp-dev/kcp#2882 Fixes: kcp-dev#32
hardys
pushed a commit
to hardys/helm-charts
that referenced
this pull request
Mar 28, 2023
Requires kcp-dev/kcp#2882 Fixes: kcp-dev#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the logical cluster admin kubeconfig is used to access both the external front-proxy endpoint, and also the shard directly via the baseURL - this won't work in the case where different CA certs are used for shard and front-proxy (such as in the helm-charts)
This only works in CI because we use the same serving-ca.crt for both shard and front-proxy, (in a future PR I will propose a change which better reflects the likely scenario in production deployments).
Fixes #2872