馃摉 Update CONTRIBUTING.md re golang version #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes bug of kcp-dev#2904 regarding go lang version in documentation. Does not improve the verify-go-versions.sh script which uses a hardcoded high level go version "1".
ncdc
changed the title
ncdc
reviewed
Apr 4, 2023
docs/content/CONTRIBUTING.md
Outdated
Comment on lines
23
to
28
| Please note that the go language version numbers in these files must exactly agree: | ||
| - Your local go/go.mod file, kcp/.ci-operator.yaml, kcp/Dockerfile, and in all the kcp/.github/workflows yaml files that specify go-version. | ||
| In kcp/.ci-operator.yaml the go version is indicated by the "tag" attribute. | ||
| In kcp/Dockerfile it is indicated by the "golang" attribute | ||
| In go.mod it is indicated by the "go" directive." | ||
| In the .github/workflows yaml files it is indicated by "go-version" |
There was a problem hiding this comment.
Thanks for this! Could you please update the formatting so it renders better when the markdown is converted to html? See https://github.com/kcp-dev/kcp/blob/d5ad69188d61b6714f4181bd1119dba23a541aed/docs/content/CONTRIBUTING.md for example:
There was a problem hiding this comment.
i think I made the change. Let me know if there are still issues.
ncdc
approved these changes
Apr 10, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2904
Does not improve the verify-go-versions.sh script which uses a hardcoded high level go version "1".
Summary
Related issue(s)
Fixes #