🐛 logicalcluster-deletion: skip bound resources #2958
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Closing & re-opening this PR to migrate it to the new Prow. Please do not be alarmed. |
kcp-ci-bot
added
dco-signoff: yes
|
/retest all |
|
@mjudeikis: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sttts is this still valid to merge? Looks green'ish |
|
/test all |
|
Yes. I just extracted it at the time because we didn't know where some flakes came from. |
Skip deleting bound resources in the logicalcluster deletor as this can race with the apibinding deletion controller. If the apibinding deletion controller deletes an APIBinding and all its instances and then the logicalcluster deletor tries to delete the collection of the same resources (because it saw the resource in discovery), it will get a 404 and go into rate limited backoff, which we don't want. Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
sttts
force-pushed
the
sttts-workspace-deletion-optimization-2
branch
from
6b1b63a
to
9d2b3a0
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 80ca853a4431607def273490d45398859b281cb9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Skip deleting bound resources in the logicalcluster deletor as this can
race with the apibinding deletion controller. If the apibinding deletion
controller deletes an APIBinding and all its instances and then the
logicalcluster deletor tries to delete the collection of the same
resources (because it saw the resource in discovery), it will get a 404
and go into rate limited backoff, which we don't want.
Taken from @ncdc's rebase PR #2945.