Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove apiresource.kcp.io apis #2992

Merged
merged 2 commits into from
Jul 11, 2023
Merged

⚠️ Remove apiresource.kcp.io apis #2992

merged 2 commits into from
Jul 11, 2023

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Jul 11, 2023 •
edited

Summary

Related issue(s)

Removes apiresource.kcp.io apis in favor of moving them to contrib-tmc

Fixes #

Release Notes

Remove apiresource.kcp.io API

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jul 11, 2023
@kcp-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 11, 2023
@mjudeikis
Remove apiresource.kcp.io apis
6c2ad7d 
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
@mjudeikis
remove apiresource.kcp.io clients
974c517 
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
@mjudeikis mjudeikis marked this pull request as ready for review July 11, 2023 18:19
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@mjudeikis
Copy link
Contributor Author

/test pull-kcp-lint

@sttts
Copy link
Member

sttts commented Jul 11, 2023

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 59ea2392e3d0e774858dc7a946e3bd324e35c1b0

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@kcp-ci-bot kcp-ci-bot merged commit 8dd1a3f into kcp-dev:main Jul 11, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjudeikis @kcp-ci-bot @sttts