Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 WIP: docs: add a sharding overview #3000

Merged
merged 1 commit into from
Oct 18, 2023
Merged

📖 WIP: docs: add a sharding overview #3000

merged 1 commit into from
Oct 18, 2023

Conversation

sttts
Copy link
Member

@sttts sttts commented Aug 16, 2023 •
edited by mjudeikis

Brain dump while being in a plane. Not proof-read.

NONE

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2023
mjudeikis
mjudeikis reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@mjudeikis mjudeikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for start. What I'm missing is "Sharding for developer", like FAQ:

  1. If my objects are hosted in the workspace (apps/v1, foo/v2,etc) and managed via APIBinding/Export - Is it enough to have single controller running per VirtualWorkspace to manage objects cross shards?
  2. As a KCP consumer/service provider ontop of KCP - do I need to care about adding my objects into cache server? How does cross shard APIBindings/APIExports are resolved?

Mostly where KCP responsibility ends and developers building optop of KCP starts

docs/content/concepts/sharding.md

# Logical Clusters and Workspace Paths

Logical clusters are defined through the existence of a `LogicalCluster` object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can shard host more than 1 logical cluster? Or logical cluster and shard are 1:1 mapping?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arbitrary many logical clusters per shard.

@mjudeikis
Copy link
Contributor

/retest

@mjudeikis
Copy link
Contributor

/approve
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b3669597133f8ebd5d985eeb797688989a43d32b

@mjudeikis
Copy link
Contributor

/retest

1 similar comment
@mjudeikis
Copy link
Contributor

/retest

@mjudeikis
Copy link
Contributor

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 17, 2023
@mjudeikis
Copy link
Contributor

/test all

@mjudeikis
Copy link
Contributor

/refresh

@kcp-ci-bot kcp-ci-bot merged commit a2fb6fd into kcp-dev:main Oct 18, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjudeikis mjudeikis mjudeikis left review comments

Assignees

@mjudeikis mjudeikis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sttts @mjudeikis @kcp-ci-bot