Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 prow fix go version validate #3019

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

mjudeikis
Copy link
Contributor

Summary

Prow go version is not checked in go version checking CI so it was missed in rebase ;/

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2023
hack/verify-go-versions.sh Outdated Show resolved Hide resolved
@mjudeikis
Copy link
Contributor Author

/retest

2 similar comments
@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis
Copy link
Contributor Author

/retest

hack/verify-go-versions.sh Outdated Show resolved Hide resolved
@mjudeikis
Copy link
Contributor Author

Ou. Multitasking.... Gonna rebase to single commit tomorrow

Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
@mjudeikis
Copy link
Contributor Author

/retest

1 similar comment
@sttts
Copy link
Member

sttts commented Oct 11, 2023

/retest

@sttts
Copy link
Member

sttts commented Oct 12, 2023

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7580424158a7d68909e8445e1bb69093b5b4de58

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@mjudeikis
Copy link
Contributor Author

/retest

5 similar comments
@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis
Copy link
Contributor Author

/retest

@kcp-ci-bot kcp-ci-bot merged commit 18b6497 into kcp-dev:main Oct 14, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants