Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 reduce log verbosity for queueing operations #3073

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jan 19, 2024

Summary

This PR reduces the log verbosity of many logging statements in kcp. I tried to debug something recently and the sheer amount of "processing key" and "queueing thing" messages that flew by made it difficult.

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md defines some guidance for log level usage and most importantly, queueing things should not be on level 1 (what i would consider the "panic" level). So I changed the levels to be

  • Level 4 for every basic enqueue/process log lines. Just enqueueing something does not change cluster state and so should not printed every single time.
  • Operations that actually change cluster state (creating/deleting/updating objects) have generally been moved to level 2.

My hope is that running kcp with -v=2 should provide a nice log of things that actually change or break, and -v=4 being a nice log level for development.

Release Notes

Reduce log verbosity for processing/queueing messages in controllers.

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2024
@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6eb878a74e9ccd568cfdc9624d0ddce18ab68c52

@mjudeikis
Copy link
Contributor

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2024
@kcp-ci-bot kcp-ci-bot merged commit ff00248 into kcp-dev:main Jan 23, 2024
18 checks passed
@xrstf xrstf deleted the fix-log-levels branch January 23, 2024 07:49
@embik
Copy link
Member

embik commented Jan 24, 2024

/kind cleanup

@kcp-ci-bot kcp-ci-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants