✨ Feature: Re-enable webhook token authentication

[ajwdev]

Summary

This simply re-enables Kubernetes Webhook Token Authentication that was previously commented out.

I verified it worked in a local setup against a custom authenticator. See below:

$ \cat me.kubeconfig
apiVersion: v1
clusters:
- cluster:
    insecure-skip-tls-verify: true
    server: https://localhost:6443/clusters/root
  name: workspace.kcp.io/current
- cluster:
    insecure-skip-tls-verify: true
    server: https://localhost:6443/clusters/root
  name: workspace.kcp.io/previous
contexts:
- context:
    cluster: workspace.kcp.io/current
    user: test
  name: workspace.kcp.io/current
- context:
    cluster: workspace.kcp.io/previous
    user: test
  name: workspace.kcp.io/previous
current-context: workspace.kcp.io/current
kind: Config
preferences: {}
users:
- name: test
  user:
    token: eyJhbGciO <SNIP> RVA


$ KUBECONFIG=me.kubeconfig kubectl kcp ws create foo --enter
error: workspaces.tenancy.kcp.io is forbidden: User "andrewwi@vmware.com" cannot create resource "workspaces" in API group "tenancy.kcp.io" at the cluster scope: access denied
zsh: exit 1     KUBECONFIG=me.kubeconfig kubectl kcp ws create foo --enter

$ \cat admin.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: me-admin
subjects:
- kind: User
  name: andrewwi@vmware.com
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: cluster-admin
  
  
$ KUBECONFIG=.kcp/admin.kubeconfig kubectl apply -f admin.yaml
clusterrolebinding.rbac.authorization.k8s.io/me-admin created

$ KUBECONFIG=me.kubeconfig kubectl kcp ws create foo --enter
Workspace "foo" (type root:organization) created. Waiting for it to be ready...
Workspace "foo" (type root:organization) is ready to use.
Current workspace is "root:foo" (type root:organization).

KCP was started with the following flags:

bin/kcp start --authentication-token-webhook-version=v1 --authentication-token-webhook-config-file=/tmp/webhook.yaml

Release Notes

- Re-enable Kubernetes Webhook Token Authentication

[kcp-ci-bot]

Hi @ajwdev. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palnabarun]

/ok-to-test

[mjudeikis]

/retest

[embik]

lgtm, leaving second approval to another maintainer.

[kcp-ci-bot]

LGTM label has been added.

Git tree hash: 2ec6497d7997b94a8ab28564a34bdeb1ca37f5ee

[mjudeikis]

/approve

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mjudeikis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment