-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freshen Makefile and update README.md #31
Conversation
- [x] Add `sudo` to revelvant commands - [x] Use named languages (bash) in fenced codeblocks - [x] Use `console` in fenced codeblocks for command output - [x] Use `install` with permission mode The permissions on `has` were 777 from `git clone`. - [x] Add option to use $PREFIX What if I don't want to install to /usr/local/bin? `make PREFIX=$HOME/.local install` now works. - [x] Add `update` target for `git pull` - [x] Include .PHONY targets
- [x] Add `sudo` to revelvant commands - [x] Use named languages (bash) in fenced codeblocks - [x] Use `console` in fenced codeblocks for command output - [x] Use `install` with permissions set The permissions on `has` were 777 from `git clone`. - [x] Add option to use $PREFIX What if I don't want to install to /usr/local/bin? `make PREFIX=$HOME/.local install` now works. - [x] Add `update` target for `git pull` - [x] Include .PHONY targets - [x] Add tests for Makefile changes - [x] Uses `bats` variables for directories - ✓ make install creates a valid installation - ✓ ..even if has is missing from directory - ✓ make update runs git pull
…into makefile-update
Thanks for the PR. To be able to merge it should pass on Travis CI. Could you please check that? I am away right now but will certainly take a look at it little later in the week. |
It was and still is, passing on my local checkout. I will add some bats' feedback and commit shortly. |
temp remove "git pull" check.
Do not be concerned about dirty working tree when running make update.
Do not be concerned about dirty working tree when running make update.
Well. That was a bit more effort than I expected. But I'm ready to start using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have happily merged it today but the make install
target is now broken on macos. any suggestions?
Sadly, some long opts dont work on macOS. had to change them to short flags :( We can work on those in future commits. Didn't want you to fix them, so committed changes to master. you can review them if that works for you on your setup. |
Freshen Makefile and update README.md
README.md
sudo
to revelvant commandsconsole
in fenced codeblocks for command outputMakefile
install
targetinstall
with permissions setThe permissions on
has
were 777 fromgit clone
.What if I don't want to install to /usr/local/bin?
make PREFIX=$HOME/.local install
now works.update
targetupdate
target forgit fetch
tests
Add tests for Makefile changes
Uses
bats
variables for directories✓ make install creates a valid installation
✓ ..even if has is missing from directory
✓ make update runs git fetch