Linting with shellcheck #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Double quote to prevent globbing and word splitting.
Don't use variables in the printf format string. Use printf "..%s.." "$foo". Update matching test to not assume whitespace is <space>
Consider 'cmd < file | ..' or 'cmd file | ..' instead.
- [x] NEW variables for 'checkmark' and 'fancy x' and tput colours
- [x] eg: `checkmark` = `\342\234\223`
- [x] eg: `PASS=${txtbold}${txtgreen}${checkmark}${txtreset}`
- [x] update `printf` statements to use `%b` for unicode variables.
- [x] Using readonly variables for
- [x] $BINARY_NAME and $VERSION
- [x] $PASS and $FAIL
- [x] refactor `.hasrc` file reading
- [x] [SC2002] Useless cat
- [x] Add new BATS tests for Unicode output
- [x] Add shellscripts to `.editorconfig` - [x] Add shellscripts to `.gitattributes`
|
Looks like I get to play unicode output parsing with travis :) I'll get back to you. |
kdabir
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Linting with shellcheck
Update Unicode PASS/FAIL output
checkmark=\342\234\223(or$'\u2713')PASS=${txtbold}${txtgreen}${checkmark}${txtreset}printfstatements to use%bfor unicode variables..hasrcfile readinghasbinary to.hastest.batsRepo scaffolding - shellscript filetype
.editorconfig.gitattributes