more tests

kdash-rs · May 10, 2021 · 45fc41d · 45fc41d
1 parent e603008
commit 45fc41d
Show file tree

Hide file tree

Showing 8 changed files with 216 additions and 9 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -42,6 +42,7 @@ openssl = { version = "0.10.34", features = ["vendored"] }
 
 [dev-dependencies]
 spectral = "0.6.0"
+faux = "0.1"
 
 [dev-dependencies.cargo-husky]
 version = "1"

diff --git a/src/app/contexts.rs b/src/app/contexts.rs
@@ -1,6 +1,6 @@
 use kube::config::{Kubeconfig, NamedContext};
 
-#[derive(Clone)]
+#[derive(Clone, Default)]
 pub struct KubeContext {
   pub name: String,
   pub cluster: String,

diff --git a/src/app/mod.rs b/src/app/mod.rs
@@ -381,6 +381,8 @@ impl App {
       self.dispatch(IoEvent::GetStatefulSets).await;
       self.dispatch(IoEvent::GetReplicaSets).await;
       self.dispatch(IoEvent::GetDeployments).await;
+
+      self.refresh = false;
     }
     // make network requests only in intervals to avoid hogging up the network
     if self.tick_count == 0 || self.is_routing {
@@ -410,6 +412,7 @@ impl App {
             }
             ActiveBlock::Logs => {
               if !self.is_streaming {
+                // do not tail to avoid duplicates
                 self.dispatch_stream(IoStreamEvent::GetPodLogs(false)).await;
               }
             }
@@ -429,9 +432,116 @@ impl App {
     if self.tick_count > self.tick_until_poll {
       self.tick_count = 0; // reset ticks
     }
+  }
+}
 
-    if self.refresh {
-      self.refresh = false;
-    }
+#[cfg(test)]
+mod tests {
+
+  use tokio::sync::mpsc;
+
+  use super::*;
+
+  #[tokio::test]
+  async fn test_on_tick_first_render() {
+    let (sync_io_tx, mut sync_io_rx) = mpsc::channel::<IoEvent>(500);
+    let (sync_io_cmd_tx, mut sync_io_cmd_rx) = mpsc::channel::<IoCmdEvent>(500);
+
+    let mut app = App {
+      tick_until_poll: 2,
+      io_tx: Some(sync_io_tx),
+      io_cmd_tx: Some(sync_io_cmd_tx),
+      ..App::default()
+    };
+
+    assert_eq!(app.tick_count, 0);
+    // test first render
+    app.on_tick(true).await;
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetKubeConfig);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetPods);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetServices);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetConfigMaps);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetStatefulSets);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetReplicaSets);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetDeployments);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetNamespaces);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetNodes);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetPods);
+
+    assert_eq!(sync_io_cmd_rx.recv().await.unwrap(), IoCmdEvent::GetCliInfo);
+
+    assert!(!app.refresh);
+    assert!(!app.is_routing);
+    assert_eq!(app.tick_count, 1);
+  }
+  #[tokio::test]
+  async fn test_on_tick_refresh_tick_limit() {
+    let (sync_io_tx, mut sync_io_rx) = mpsc::channel::<IoEvent>(500);
+    let (sync_io_stream_tx, mut sync_io_stream_rx) = mpsc::channel::<IoStreamEvent>(500);
+    let (sync_io_cmd_tx, mut sync_io_cmd_rx) = mpsc::channel::<IoCmdEvent>(500);
+
+    let mut app = App {
+      tick_until_poll: 2,
+      tick_count: 2,
+      refresh: true,
+      io_tx: Some(sync_io_tx),
+      io_stream_tx: Some(sync_io_stream_tx),
+      io_cmd_tx: Some(sync_io_cmd_tx),
+      ..App::default()
+    };
+
+    assert_eq!(app.tick_count, 2);
+    // test first render
+    app.on_tick(false).await;
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::RefreshClient);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetKubeConfig);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetPods);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetServices);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetConfigMaps);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetStatefulSets);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetReplicaSets);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetDeployments);
+
+    assert_eq!(
+      sync_io_stream_rx.recv().await.unwrap(),
+      IoStreamEvent::RefreshClient
+    );
+    assert_eq!(sync_io_cmd_rx.recv().await.unwrap(), IoCmdEvent::GetCliInfo);
+
+    assert!(!app.refresh);
+    assert!(!app.is_routing);
+    assert_eq!(app.tick_count, 0);
+  }
+  #[tokio::test]
+  async fn test_on_tick_routing() {
+    let (sync_io_tx, mut sync_io_rx) = mpsc::channel::<IoEvent>(500);
+    let (sync_io_stream_tx, mut sync_io_stream_rx) = mpsc::channel::<IoStreamEvent>(500);
+
+    let mut app = App {
+      tick_until_poll: 2,
+      tick_count: 2,
+      is_routing: true,
+      refresh: false,
+      io_tx: Some(sync_io_tx),
+      io_stream_tx: Some(sync_io_stream_tx),
+      ..App::default()
+    };
+
+    app.push_navigation_stack(RouteId::Home, ActiveBlock::Logs);
+
+    assert_eq!(app.tick_count, 2);
+    // test first render
+    app.on_tick(false).await;
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetNamespaces);
+    assert_eq!(sync_io_rx.recv().await.unwrap(), IoEvent::GetNodes);
+
+    assert_eq!(
+      sync_io_stream_rx.recv().await.unwrap(),
+      IoStreamEvent::GetPodLogs(false)
+    );
+
+    assert!(!app.refresh);
+    assert!(!app.is_routing);
+    assert_eq!(app.tick_count, 0);
   }
 }
diff --git a/src/cmd/mod.rs b/src/cmd/mod.rs
@@ -8,7 +8,7 @@ use anyhow::anyhow;
 use std::sync::Arc;
 use tokio::sync::Mutex;
 
-#[derive(Debug)]
+#[derive(Debug, PartialEq)]
 pub enum IoCmdEvent {
   GetCliInfo,
   GetDescribe {

diff --git a/src/handlers/mod.rs b/src/handlers/mod.rs
@@ -407,7 +407,7 @@ fn copy_to_clipboard(content: String) {
 
 #[cfg(test)]
 mod tests {
-  use crate::app::pods::KubePod;
+  use crate::app::{contexts::KubeContext, pods::KubePod};
 
   use super::*;
 
@@ -529,4 +529,21 @@ mod tests {
     handle_scroll(&mut app, true, false).await;
     assert_eq!(app.data.logs.state.selected(), Some(0));
   }
+
+  #[tokio::test]
+  async fn test_context_switch() {
+    let mut app = App::default();
+    let ctx = KubeContext {
+      name: "test".into(),
+      ..KubeContext::default()
+    };
+    app.data.contexts.set_items(vec![ctx]);
+
+    assert_eq!(app.data.selected.context, None);
+    app.route_contexts();
+    handle_route_events(Key::Enter, &mut app).await;
+
+    assert_eq!(app.data.selected.context, Some("test".into()));
+    assert!(app.refresh);
+  }
 }
diff --git a/src/network/mod.rs b/src/network/mod.rs
@@ -10,7 +10,7 @@ use kube::Client;
 use std::sync::Arc;
 use tokio::sync::Mutex;
 
-#[derive(Debug)]
+#[derive(Debug, PartialEq)]
 pub enum IoEvent {
   GetKubeConfig,
   GetNodes,

diff --git a/src/network/stream.rs b/src/network/stream.rs
@@ -11,7 +11,7 @@ use std::{sync::Arc, time::Duration};
 use tokio::sync::Mutex;
 use tokio_stream::StreamExt;
 
-#[derive(Debug)]
+#[derive(Debug, PartialEq)]
 pub enum IoStreamEvent {
   RefreshClient,
   GetPodLogs(bool),
@@ -94,6 +94,7 @@ impl<'a> NetworkStream<'a> {
       follow: true,
       previous: false,
       //   timestamps: true,
+      // tail only on first call to avoid duplicates on disconnect
       tail_lines: if tail { Some(10) } else { Some(0) },
       ..Default::default()
     };