Fix apt omitting final result #1022
Conversation
Before this change, the last element in a search result would always be omitted. The output of the `apt` command does not have a trailing newline (at least on my machine with apt 2.0.9), so that literal newline does not match, so the entire package is skipped. The crux here is when doing an exact search (either with the mpm --exact flag or adding ^ and $ to the query), the only entry is also the last entry, and so there are no matches. Since installing forces the "exact" search behavior (which we want), the install command will always fail with no matches, even if there is exactly one match. Updates the regex to require 0 or 1 newlines so all the lines still get captured. Also tweaked the comment to reflect that.
Since I did this in reverse TDD, I reverted the change and confirmed the test fails for the expected reason.
|
Thanks @izzergh for the detailed troubleshooting. That's a nice catch and a cool PR. And thanks for taking the time to implement a unittest. I'm looking at the details now. I'll try to think of eventual edge-cases but after a first pass it might be good enough to merge upstream. I'll keep you in the loop. |
kdeldycke
added
🖥 platform: Linux
|
OK so this looks good to me. I had doubts about the way You made me realize that we should probably dedicate a couple of unittests to the regexps alone, but that is another job altogether. |
|
For the record, I'm going to tag an release mpm v5.13.1 today. So you should find to fix available in that release. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
My old issue (#881) was still giving me trouble with the latest version of
meta-package-manager. This time I cracked it open and fiddled with the regex until I found the problem: it's expecting a newline in the description. This works great for a verbose search where most descriptions are multiple lines, but in practice (i.e. when usinginstallorsearch --exact), the descriptions are one line, without a trailing newline. It's kinda hard to catch because an inexact search will show a few results, but it's always one fewer thanapt searchgets you.I just changed the literal
\nto\n?, so it should be backwards compatible as well.apt-mintdoesn't look for newlines and I don't use mint, so I didn't touch that.I also added a unit test per the development guidelines. It's my first unit test in Python, let me know if I over- or under-did it. Thanks!