Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates homebrew run on Linux #188

Merged

Conversation

hedinfaok
Copy link
Contributor

First off, thanks for the great tool :)

This PR adds Linux as a supported platform for Homebrew. After adding LINUX to the list of supported platforms, brew didn't return a list of installed software. It turns out that brew on Linux needs the path to brew to remain a symlink to properly list installed packages.

# Returns nothing.
/home/linuxbrew/.linuxbrew/Homebrew/bin/brew list --versions
# Returns the list as expected.
/home/linuxbrew/.linuxbrew/bin/brew list --versions

The fix was to override the cli_path method to get the cli path without following the symlink.

# Homebrew on linux uses the symlink path to set environment variables.
cli_path = Path.cwd() / Path(cli_path)

The method could be removed from this class if base.py was altered instead.

@github-actions github-actions bot added the CI/CD label Dec 19, 2020
@kdeldycke
Copy link
Owner

Thanks @hedinfaok for the PR! Happy that you found my little pet-project useful! 🤗

I had some plans to add Linux Homebrew in the future but you beat me to it! 😁

I looked at your PR and I think I'll merge it right away: the failing tests are also broken on the develop branch, and your changes doesn't seems to make the situation worse.

So I'll merge your PR to not have it rot, and I'll try to fix the tests and cut a release in the next few weeks.

Thanks again @hedinfaok for the contribution! 👍

@kdeldycke kdeldycke merged commit c3f0670 into kdeldycke:develop Dec 20, 2020
@kdeldycke kdeldycke added 🖥 platform: Linux Linux, Windows Subsystem for Linux v2 📦 manager: brew brew 🤖 ci Continuous integration, tests, automation and management of the project and removed CI/CD labels Dec 20, 2020
kdeldycke added a commit that referenced this pull request Dec 20, 2020
@hedinfaok
Copy link
Contributor Author

@kdeldycke Thanks for merging!

kdeldycke added a commit that referenced this pull request Dec 30, 2020
kdeldycke added a commit that referenced this pull request Jan 3, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 ci Continuous integration, tests, automation and management of the project 📦 manager: brew brew 🖥 platform: Linux Linux, Windows Subsystem for Linux v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants