New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates homebrew run on Linux #188
Updates homebrew run on Linux #188
Conversation
Thanks @hedinfaok for the PR! Happy that you found my little pet-project useful! 🤗 I had some plans to add Linux Homebrew in the future but you beat me to it! 😁 I looked at your PR and I think I'll merge it right away: the failing tests are also broken on the So I'll merge your PR to not have it rot, and I'll try to fix the tests and cut a release in the next few weeks. Thanks again @hedinfaok for the contribution! 👍 |
@kdeldycke Thanks for merging! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
First off, thanks for the great tool :)
This PR adds Linux as a supported platform for Homebrew. After adding LINUX to the list of supported platforms,
brew
didn't return a list of installed software. It turns out that brew on Linux needs the path tobrew
to remain a symlink to properly list installed packages.The fix was to override the
cli_path
method to get the cli path without following the symlink.The method could be removed from this class if base.py was altered instead.