Skip to content

Commit

Permalink
improve API
Browse files Browse the repository at this point in the history
  • Loading branch information
kostyadeev committed Oct 18, 2023
1 parent 3fd497f commit eb6950e
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
16 changes: 10 additions & 6 deletions pyonwater/meter.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class Meter:

def __init__(self, reader: MeterReader, meter_info: MeterInfo) -> None:
"""Initialize the meter."""
self.reader = reader
self._reader = reader
self.last_historical_data: list[DataPoint] = []

self._reading_data: Reading | None = None
Expand All @@ -40,12 +40,12 @@ def __init__(self, reader: MeterReader, meter_info: MeterInfo) -> None:
@property
def meter_uuid(self) -> str:
"""Return meter UUID."""
return self.reader.meter_uuid
return self._reader.meter_uuid

@property
def meter_id(self) -> str:
"""Return meter ID."""
return self.reader.meter_id
return self._reader.meter_id

@property
def native_unit_of_measurement(self) -> str:
Expand All @@ -54,12 +54,14 @@ def native_unit_of_measurement(self) -> str:

async def read_meter_info(self, client: Client) -> None:
"""Read the latest meter info."""
self._meter_info = await self.reader.read_meter_info(client)
self._meter_info = await self._reader.read_meter_info(client)
self._reading_data = self._meter_info.reading

async def read_historical_data(self, client: Client, days_to_load: int) -> None:
async def read_historical_data(
self, client: Client, days_to_load: int
) -> list[DataPoint]:
"""Read historical data for N last days."""
historical_data = await self.reader.read_historical_data(
historical_data = await self._reader.read_historical_data(
client=client, days_to_load=days_to_load
)

Expand All @@ -79,6 +81,8 @@ async def read_historical_data(self, client: Client, days_to_load: int) -> None:
# If it the same date - take more data
self.last_historical_data = historical_data

return historical_data

@property
def meter_info(self) -> MeterInfo:
"""Return MeterInfo."""
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "pyonwater"
version = "0.3.3"
version = "0.3.4"
description = "EyeOnWater client library."
authors = []
license = "MIT"
Expand Down

0 comments on commit eb6950e

Please sign in to comment.