Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly M3 Implementation of ESRNN #7

Closed
FangSimon opened this issue Jun 15, 2020 · 3 comments
Closed

Monthly M3 Implementation of ESRNN #7

FangSimon opened this issue Jun 15, 2020 · 3 comments

Comments

@FangSimon
Copy link

Hi there,

Thanks a lot for the great implementation. I am trying to fit the monthly M3 data, but the model does not seem to be training. My data looks as follows:

image

image

image

image

Note that the y_hat_naive2 is in fact just the simple naive.

When, I fit the model, I get the following:

image

In an earlier issue, it has been mentioned that it could possibly be a mismatch in forecasting horizon, but after playing around with it, I don't see any improvement. Below, you can find a link to the colab notebook so you can reproduce it.

https://colab.research.google.com/drive/1rFz5SskOqKuaxn3ijZUJwIPBqDGy7AK1?usp=sharing

Thanks a lot!

Simon

@chendiva
Copy link

I have the same issue, have you solved it?

@FangSimon
Copy link
Author

No I unfortunately, I have not solved it.

@AzulGarza
Copy link
Collaborator

Hi!

We reviewed the colab notebook and made a few small changes to resolve the issue. In particular, we believe the following points will be useful for you:

  • Check that the frequencies of the datasets (X_train_df, y_train_df, X_test_df, y_test_df) are all the same. With this verified, the ESRNN argument frequency = None can be used; this argument will automatically detect the frequency of the time series and use it to generate the predictions.
  • Check the output_size argument. This argument determines the number of predictions that will be generated per time series. If this number is less than the size of the time series in the test set, the remaining values will be set to NA, so the OWA will be NA.

Thanks for your comments!

Reviewed colab notebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants