-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I have some question about the input and output #9
Comments
Hi Chendiva,
Try to parse your data as mentioned in the README file (
https://github.com/kdgutier/esrnn_torch) with the price data in the y_df,
try to add a simple constant in the X_df to use if you don't have any
exogenous variable. The algorithm needs you to plug with the same column
names as specified by the README dataframes, the lag variables are
calculated within the algorithm. Good luck.
…On Tue, Jul 28, 2020 at 9:33 PM chendiva ***@***.***> wrote:
Hi there,
So I am now using a time series data which only have two columns- Date and
Price. So I am wondering if I can use this algorithm in this situation, and
let the algorithm train the model only on price, and predict the price in
the future. In other words,
I am wondering if this model can separate my data automatically, so that I
will not need to separate by "lag" myself. Thank you for your help!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYDACOZT46DNYONQ4FAZ2LR5537RANCNFSM4PLC4U2A>
.
|
Hi, |
I recommend you to always have benchmarks to test complex models as the
ESRNN, in our case we included the OWA metric in the validation set to
compare the relative performance vs the Naive2 model as done in the M4
competition. Take extra care of the learning rate hyperparameters when
tuning your model.
…On Tue, Jul 28, 2020 at 11:55 PM chendiva ***@***.***> wrote:
Hi,
Will it affect the forecasting result when I add the exogenous variable?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYDACOYO7A676K5ELLF2RDR56MR3ANCNFSM4PLC4U2A>
.
|
Sorry , I am still confused, if I add the exogenous variable as you recommend, will it affect the result? Is the x variable in your example added by you? Or this x is originally included in the dataset and use for forecasting? |
I would recommend to answer the question empirically (with the OWA metric),
try the model and see if the performance remains acceptable.
…On Wed, Jul 29, 2020 at 12:07 AM chendiva ***@***.***> wrote:
Sorry , I am still confused, if I add the exogenous variable as you
recommend, will it affect the result? Is the x variable in your example
added by you? Or this x is originally included in the dataset and use for
forecasting?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYDACOJEARSPRY267WNAHTR56OABANCNFSM4PLC4U2A>
.
|
This also give me NaN for my y_hat |
Hi chendiva,
I checked the bug, the ESRNN produces correct outputs that fail to merge in
the predict method to the X_test_df if the frequency of the dataset is not
correctly specified.
For instance in the M3 dataset the frequency seems to be 'MS' for dates of
the beginning of the month. In the bug reported before they were using 'M'
frequency for dates at the end of the month. Let me know if this solves the
problem.
…On Wed, Jul 29, 2020 at 9:08 PM chendiva ***@***.***> wrote:
This also give me NaN for my y_hat
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYDACJMG2TRGSEMTY7QJW3R6DBXHANCNFSM4PLC4U2A>
.
|
Hi, how can I decide the frequency then? |
When you instantiate the ESRNN model
model = ESRNN(params,...,frequency=‘MS’)
…On Wed, 29 Jul 2020 at 11:13 pm, chendiva ***@***.***> wrote:
Hi, how can I decide the frequency then?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYDACO76T7OWOQABBMBZH3R6DQNNANCNFSM4PLC4U2A>
.
|
That is a protection for the network that aims to protect the model from
nan values. Clean nans from the data before using the ESRNN.
…On Wed, 29 Jul 2020 at 11:17 pm, chendiva ***@***.***> wrote:
I actually use my dataset, not the M3 now. My dataset is daily base. so I
set the frequency = 'D', but I then got the error like this:
[image: image]
<https://user-images.githubusercontent.com/22489898/88876633-b3145880-d1f1-11ea-9e72-9cb9161432ee.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYDACJL7NY4Z7VQXW2RRIDR6DQ6HANCNFSM4PLC4U2A>
.
|
Yes, I actually check the dataframe with this command: df.isnull().values.any(), which returns me False. But I still get the above result |
Have you tried printing those unique_ids?
Also isnan function?
…On Wed, 29 Jul 2020 at 11:22 pm, chendiva ***@***.***> wrote:
Yes, I actually check the dataframe with this command:
df.isnull().values.any(), which returns me False. But I still get the above
result
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYDACPHZNUSO3FHTCM6TUDR6DROFANCNFSM4PLC4U2A>
.
|
You are treating the unique_ids as a numeric variable. I suggest to check
the README markdown of the github in which the input dataframes for the
model are explained with detail.
…On Wed, 29 Jul 2020 at 11:30 pm, chendiva ***@***.***> wrote:
I actually got this after using the function you mentioned:
[image: image]
<https://user-images.githubusercontent.com/22489898/88877408-63369100-d1f3-11ea-9fff-69b4875d9096.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYDACOUL5GFLZFK3W5DBT3R6DSLRANCNFSM4PLC4U2A>
.
|
Hi, there, I got the same problem with yours, have you solved it? I tried to slice the m4 data provided from the prepare_m4_data function, and found out that even I make sure the identifier in the training set and testing set are the same, it still generated NaN for the evaluation methods and the predictions, which was weird. |
Hi! I think this answer could be useful. |
Hi, |
No, I haven't solved the problem yet, even I tried his method. |
Hi,
|
Have you solved the issue Worben? |
Hi there,
So I am now using a time series data which only have two columns- Date and Price. So I am wondering if I can use this algorithm in this situation, and let the algorithm train the model only on price, and predict the price in the future. In other words,
I am wondering if this model can separate my data automatically, so that I will not need to separate by "lag" myself. Thank you for your help!
The text was updated successfully, but these errors were encountered: